Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(intersection): target type param #6325

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 6, 2024

Description

autowarefoundation/autoware_launch#851

set the target vehicle type for

  • stuck vehicle detection
  • yield stuck vehicle detection
  • collision detection

Tests performed

https://evaluation.tier4.jp/evaluation/reports/a40b1c77-0f2a-5017-95e8-f397bf4c3f25?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2024
@soblin soblin force-pushed the chore/target-type-param branch from 3cd6804 to aa49863 Compare February 6, 2024 01:48
@soblin soblin marked this pull request as ready for review February 6, 2024 01:50
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 200 lines in your changes are missing coverage. Please review.

Comparison is base (3a10282) 14.86% compared to head (f207176) 14.85%.
Report is 3 commits behind head on main.

Files Patch % Lines
...avior_velocity_intersection_module/src/manager.cpp 0.00% 0 Missing and 171 partials ⚠️
...tersection_module/src/scene_intersection_stuck.cpp 0.00% 21 Missing ⚠️
...ection_module/src/scene_intersection_collision.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6325      +/-   ##
==========================================
- Coverage   14.86%   14.85%   -0.01%     
==========================================
  Files        1845     1845              
  Lines      126659   126726      +67     
  Branches    37883    37946      +63     
==========================================
  Hits        18830    18830              
- Misses      86664    86684      +20     
- Partials    21165    21212      +47     
Flag Coverage Δ *Carryforward flag
differential 4.51% <0.00%> (?)
total 14.88% <ø> (+0.01%) ⬆️ Carriedforward from b574523

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin force-pushed the chore/target-type-param branch from aa49863 to f207176 Compare February 7, 2024 08:38
@soblin soblin merged commit 42ce747 into autowarefoundation:main Feb 8, 2024
19 of 24 checks passed
@soblin soblin deleted the chore/target-type-param branch February 8, 2024 01:03
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants